Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
F
Forge
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 425
    • Issues 425
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 22
    • Merge Requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Forge Core Developers
  • Forge
  • Merge Requests
  • !3212

Merged
Created Sep 30, 2020 by Tim Mocny@NorthmocDeveloper

Embalm/Eternalize cleanup

  • Overview 0
  • Commits 5
  • Changes 6

Accompanies going over the FTP to make sure all files are present and correctly named.

Users can now find exact filenames for embalm/eternalize tokens in appropriate editions, just like other tokens.

@friarsol while embalm/eternalize cards are copies, they are also tokens according to Oracle and even how Forge categorizes them, so I think it's OK to put them in the [tokens] list?

Set code up to better accomodate any future alternate images that might occur from reprints, etc.

Also added another layer to ImageFetcher (thanks @kevlahnota ) to further insulate users from Forge not being able to find their files.

Closes #1602 (closed)

Also aligned reminder text a little better to Oracle. Embalm looks great, but note "and" instead of "," for Eternalize:

image

Edited Oct 01, 2020 by Tim Mocny
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: embalm_eternalize